feat: add the ability to create and sign while user is offline #85

s · 2024-05-28T10:13:39Z

s commented

2024-05-28 10:13:39 +00:00

closes #73

s added 5 commits 2024-05-28 10:13:39 +00:00

fix: use kind 27235 in place of kind 1 wherever possible 90734196e5

fix: use kind 0 event for nostr joining block 9bb62cf966

Merge pull request 'fix: use kind 27235 in place of kind 1' (#80 ) from issue-76 into main

Release / build_and_release (push) Successful in 1m5s

Details

a3c421d34a

Reviewed-on: https://git.sigit.io/sig/it/pulls/80
Reviewed-by: Y <yury@4gl.io>

feat: add the ability to create and sign while user is offline c3c9bf772d

Merge branch 'staging' into issue-73 3ff96e453c

y approved these changes 2024-05-28 10:20:57 +00:00

src/components/copyToClipboard.tsx

						
				@ -0,0 +17,4 @@

				  return (

				    <Box

				      sx={{

y commented

2024-05-28 10:16:01 +00:00

it would be nice to move css logic into separate file

s commented

2024-05-28 10:26:03 +00:00

it would be nice to move css logic into separate file

This is a simple utility component, I think it's fine to add inline style in this case. Otherwise, I'll create a folder and separate .scss file just for 1 class

> it would be nice to move css logic into separate file This is a simple utility component, I think it's fine to add inline style in this case. Otherwise, I'll create a folder and separate .scss file just for 1 class

s marked this conversation as resolved

src/controllers/AuthController.ts

						
				@ -59,3 +59,3 @@

				    const authEvent: EventTemplate = {

				      kind: 1,

				      kind: 27235,

y commented

2024-05-28 10:19:35 +00:00

it would be nice to use kinds object from nostr-tools

it would be nice to use `kinds` object from `nostr-tools`

s commented

2024-05-28 10:27:21 +00:00

it would be nice to use kinds object from nostr-tools

This change isn't related to this PR. It appeared here because staging wasn't in sync with main

> it would be nice to use `kinds` object from `nostr-tools` This change isn't related to this PR. It appeared here because staging wasn't in sync with main

👍 1

s marked this conversation as resolved

s merged commit 47c545b7f1 into staging

2024-05-28 10:27:40 +00:00

s deleted branch issue-73

2024-05-28 10:27:41 +00:00

s referenced this issue from a commit

2024-05-28 10:27:42 +00:00

Merge pull request 'feat: add the ability to create and sign while user is offline' (#85) from issue-73 into staging

Sign in to join this conversation.

No reviewers