sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

feat: add the ability to create and sign while user is offline #85

Merged
s merged 5 commits from issue-73 into staging 2024-05-28 10:27:40 +00:00
Conversation 1 Commits 5 Files Changed 7 +266 -97
s commented 2024-05-28 10:13:39 +00:00
Owner
Copy Link

closes #73

closes #73
s added 5 commits 2024-05-28 10:13:39 +00:00
Merge pull request 'fix: use kind 27235 in place of kind 1' (#80) from issue-76 into main
All checks were successful
Release / build_and_release (push) Successful in 1m5s
Details
a3c421d34a 
Reviewed-on: https://git.sigit.io/sig/it/pulls/80
Reviewed-by: Y <yury@4gl.io>
y approved these changes 2024-05-28 10:20:57 +00:00
src/components/copyToClipboard.tsx
@ -0,0 +17,4 @@
return (
<Box
sx={{
y commented 2024-05-28 10:16:01 +00:00
Owner
Copy Link

it would be nice to move css logic into separate file

it would be nice to move css logic into separate file
s commented 2024-05-28 10:26:03 +00:00
Author
Owner
Copy Link

it would be nice to move css logic into separate file

This is a simple utility component, I think it's fine to add inline style in this case. Otherwise, I'll create a folder and separate .scss file just for 1 class

> it would be nice to move css logic into separate file This is a simple utility component, I think it's fine to add inline style in this case. Otherwise, I'll create a folder and separate .scss file just for 1 class
s marked this conversation as resolved
src/controllers/AuthController.ts
@ -59,3 +59,3 @@
const authEvent: EventTemplate = {
kind: 1,
kind: 27235,
y commented 2024-05-28 10:19:35 +00:00
Owner
Copy Link

it would be nice to use kinds object from nostr-tools

it would be nice to use `kinds` object from `nostr-tools`
s commented 2024-05-28 10:27:21 +00:00
Author
Owner
Copy Link

it would be nice to use kinds object from nostr-tools

This change isn't related to this PR. It appeared here because staging wasn't in sync with main

> it would be nice to use `kinds` object from `nostr-tools` This change isn't related to this PR. It appeared here because staging wasn't in sync with main
👍 1
s marked this conversation as resolved
s merged commit 47c545b7f1 into staging 2024-05-28 10:27:40 +00:00
s deleted branch issue-73 2024-05-28 10:27:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
y
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#85
No description provided.
Delete Branch "issue-73"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?