New Release #200

Merged

b merged 9 commits from staging into main 2024-09-12 12:17:47 +00:00

Conversation 1 Commits 9 Files Changed 9 +42 -16

eugene commented 2024-09-12 12:09:00 +00:00

Owner

Copy Link

No description provided.

eugene added 8 commits 2024-09-12 12:09:01 +00:00

fix: add types to rootReducer, rename userRobotImage types 70f646444b

Merge pull request #191 from lint-0-warnings into staging ... 1d1c675dd7

Reviewed-on: #191
Reviewed-by: s

fix: outdated cache checks f0ba9da8af

Merge branch 'staging' into cache-checks-9-9 0244090c6a

chore(git): merge pull request #192 from cache-checks-9-9 into staging ... e2b3dc13fb

Reviewed-on: #192
Reviewed-by: s <s@noreply.git.nostrdev.com>

fix: processing gift wraps and notifications (#193) ... 235e76be4e

This change will potentially close multiple issues related to the gift-wrapped events processing (#168, #158). Further testing will be required to confirm before closing each.

The commented-out code causes the race condition during the processing of the gift wraps with sigits.

During the processing we perform checks to see if sigit is outdated. In cases where sigit includes multiple signers it's possible for a signer to receive multiple sigit updates at once (especially noticeable for 3rd, 4th signer). Due to async nature of processing we can have same sigit enter processing flow with different states. Since this code also updates user's app state, which includes uploads to the blossom server it takes time to upload local user state which causes both to check against the stale data and un-updated app state. This results in both sigits being "new" and both proceed to update user state and upload app data. We have no guarantees as in which event will update last, meaning that the final state we end up with could be already stale.

The issue is also complicated due to the fact that we mark the gift wraps as processed and it's impossible to update the state without creating a new gift wrap with correct state and processing it last to overwrite stale state.

This is temporary solution to stop broken sigit states until proper async implementation is ready.

Co-authored-by: b
Reviewed-on: #193
Reviewed-by: eugene <eugene@nostrdev.com>
Co-authored-by: enes <mulahasanovic@outlook.com>
Co-committed-by: enes <mulahasanovic@outlook.com>

fix: remove unstable fetch events loop 5f0234a358

Merge pull request #199 from hotfix-remove-loop-9-12 into staging ... 32a6f9d7a3

Reviewed-on: #199
Reviewed-by: eugene <eugene@nostrdev.com>

eugene added 1 commit 2024-09-12 12:09:42 +00:00

Merge branch 'main' into staging bf1b3beb63

enes approved these changes 2024-09-12 12:11:37 +00:00

b merged commit 675a763af3 into main 2024-09-12 12:17:47 +00:00

b referenced this issue from a commit 2024-09-12 12:17:49 +00:00

Merge pull request 'New Release' (#200) from staging into main

Sign in to join this conversation.

Reviewers

No Reviewers

enes

Labels

Clear labels

Kind/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#200

No description provided.