sigit/sigit.io
7
2
Fork 0
Code Issues24 Pull Requests1 Actions Packages Projects1 Releases6 Wiki Activity

New Release #200

Merged
b merged 9 commits from staging into main 2024-09-12 12:17:47 +00:00
Conversation 1 Commits 9 Files Changed 9 +42 -16
eugene commented 2024-09-12 12:09:00 +00:00
Owner
No description provided.
eugene added 8 commits 2024-09-12 12:09:01 +00:00 
Reviewed-on: 
Reviewed-by: s
Reviewed-on: 
Reviewed-by: s <s@noreply.git.nostrdev.com>
This change will potentially close multiple issues related to the gift-wrapped events processing (, ). Further testing will be required to confirm before closing each.

The commented-out code causes the race condition during the processing of the gift wraps with sigits.

During the processing we perform checks to see if sigit is outdated. In cases where sigit includes multiple signers it's possible for a signer to receive multiple sigit updates at once (especially noticeable for 3rd, 4th signer). Due to async nature of processing we can have same sigit enter processing flow with different states. Since this code also updates user's app state, which includes uploads to the blossom server it takes time to upload local user state which causes both to check against the stale data and un-updated app state. This results in both sigits being "new" and both proceed to update user state and upload app data. We have no guarantees as in which event will update last, meaning that the final state we end up with could be already stale.

The issue is also complicated due to the fact that we mark the gift wraps as processed and it's impossible to update the state without creating a new gift wrap with correct state and processing it last to overwrite stale state.

This is temporary solution to stop broken sigit states until proper async implementation is ready.

Co-authored-by: b
Reviewed-on: 
Reviewed-by: eugene <eugene@nostrdev.com>
Co-authored-by: enes <mulahasanovic@outlook.com>
Co-committed-by: enes <mulahasanovic@outlook.com>
Reviewed-on: 
Reviewed-by: eugene <eugene@nostrdev.com>
eugene added 1 commit 2024-09-12 12:09:42 +00:00
enes approved these changes 2024-09-12 12:11:37 +00:00
b merged commit 675a763af3 into main 2024-09-12 12:17:47 +00:00
Sign in to join this conversation.
No Reviewers
enes
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#200
No description provided.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?