sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Offline flow separation #304

Merged
b merged 13 commits from 231-offline-flow into staging 2025-01-22 13:05:30 +00:00
Conversation 3 Commits 13 Files Changed 18 +845 -723
enes commented 2025-01-20 18:44:01 +00:00
Member
Copy Link

Closes #181:

  • tested on amber with 2 signers (desktop and mobile) with exports, manual file transfer and signing

Closes #224:

BOTH/EITHER of them could/should be usable for offline flow (no difference in flow)

  • it's possible to use both, more testing is required to confirm, eg: What happens when we use this combination but meta.json and mark value (signature) is uploaded to a blossom at one point?

Closes #231

Confirm decryption order (above)

  • fixed ability to decrypt for all counterparties

Test (and fix) offline flow for encrypted and unencrypted.

  • split the offline and online flow with separate buttons
  • removed exporting from the Sign page, after singing export is possible from verify page

Support offline flow for signature marks on blossom

  • signing page has an additional button for local signing which skips signature upload and adds them directly to meta.json like usual

  • create page

    • additional button to initiate offline flow manually, skipping sending notifications and uploads
    • offline flow no longer automatically downloads the file, if first signer it navigates to a sign page, otherwise it goes to verify page where you can export files normally for sharing
Closes #181: - tested on amber with 2 signers (desktop and mobile) with exports, manual file transfer and signing Closes #224: >BOTH/EITHER of them could/should be usable for offline flow (no difference in flow) - it's possible to use both, more testing is required to confirm, eg: What happens when we use this combination but `meta.json` and mark value (signature) is uploaded to a blossom at one point? Closes #231 >Confirm decryption order (above) - fixed ability to decrypt for all counterparties >Test (and fix) offline flow for encrypted and unencrypted. - split the offline and online flow with separate buttons - removed exporting from the Sign page, after singing export is possible from verify page >Support offline flow for signature marks on blossom - signing page has an additional button for local signing which skips signature upload and adds them directly to `meta.json` like usual - create page - additional button to initiate offline flow manually, skipping sending notifications and uploads - offline flow no longer automatically downloads the file, if first signer it navigates to a sign page, otherwise it goes to verify page where you can export files normally for sharing
enes added 11 commits 2025-01-20 18:44:02 +00:00
feat(export): add icons and make encrypted be first/top option
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 38s
Details
99d562a3ed
enes commented 2025-01-20 19:43:35 +00:00
Author
Member
Copy Link

@b
On create page, we only have an option to export as encrypted (the handleCreateOffline, previously offline flow). We didn't have unencrypted option. If it's needed, we can open a separate issue.

@b On create page, we only have an option to export as encrypted (the `handleCreateOffline`, previously offline flow). We didn't have unencrypted option. If it's needed, we can open a separate issue.
enes added 1 commit 2025-01-20 20:24:54 +00:00
refactor(offline): update strings, create offline navigate to sign/verify w/o auto download
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 39s
Details
a4310675c1
eugene commented 2025-01-22 11:52:24 +00:00
Owner
Copy Link

I think it looks good. While the PR description is good/clear, it would be easier to analyse the code if a separate PR was opened for each issue (appreciate that it's not always possible or makes sense).

I think it looks good. While the PR description is good/clear, it would be easier to analyse the code if a separate PR was opened for each issue (appreciate that it's not always possible or makes sense).
eugene approved these changes 2025-01-22 11:52:49 +00:00
b added 1 commit 2025-01-22 12:10:07 +00:00
Merge branch 'staging' into 231-offline-flow
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details
c45e3912a2
b merged commit feea3197d0 into staging 2025-01-22 13:05:30 +00:00
b deleted branch 231-offline-flow 2025-01-22 13:05:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
eugene
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#304
No description provided.
Delete Branch "231-offline-flow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?