fix(pdf): dynamic mark scaling #165

enes · 2024-08-26T12:05:53Z

enes commented

2024-08-26 12:05:53 +00:00

Closes #146

enes added 5 commits 2024-08-26 12:05:53 +00:00

fix(drawing): clamp DrawField within img 2f54184625

Closes #154

fix(pdf): font style consistency 31f36750cd

fix(pdf): scaling and font styles consistency ac3186a02e

Closes #146

fix(pdf): add border to style ecc1707212

fix(pdf): dynamic mark scaling ea09daa669

Caveat: scaling is not fluid, refresh is required

enes added 1 commit 2024-08-26 12:10:24 +00:00

refactor(pdf): remove unused code 8c5be3713d

eugene requested changes 2024-08-27 09:34:15 +00:00

Dismissed

eugene left a comment

Looks good overall, although I would suggest that sizing should change dynamically if the user changes the size of the browser.

I would suggest:

either explore that possibility as part of this PR
or, if it falls outside of the scope of this PR, add some comments in order to make it clear that this PR will not dynamically change the size of the marks

Looks good overall, although I would suggest that sizing should change dynamically if the user changes the size of the browser. I would suggest: - either explore that possibility as part of this PR - or, if it falls outside of the scope of this PR, add some comments in order to make it clear that this PR will not dynamically change the size of the marks

enes added 1 commit 2024-08-27 13:25:29 +00:00

fix(pdf): scaling on resize, add avatars to counterpart select 4712031615

enes added 1 commit 2024-08-27 14:11:05 +00:00

fix(drawfield): match label and select 923a47b4d0

enes added 1 commit 2024-08-27 15:28:28 +00:00

fix(pdf): add proper default width value a442e71087

enes added 1 commit 2024-08-28 09:41:37 +00:00

fix(pdf): reuse content width function 59c3fc69a2

enes requested review from eugene 2024-08-28 10:46:38 +00:00

eugene approved these changes 2024-08-28 11:20:07 +00:00

eugene left a comment

Nice one, and adding the useScale hook looks good