sigit/sigit.io
6
2
Fork 0
Code Issues 41 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

fix(pdf): dynamic mark scaling #165

Merged
enes merged 9 commits from 146-pdf-scaling into staging 2024-08-28 11:23:34 +00:00
Conversation 0 Commits 9 Files Changed 15 +285 -107
enes commented 2024-08-26 12:05:53 +00:00
Member
Copy Link

Closes #146

Closes #146
enes added 5 commits 2024-08-26 12:05:53 +00:00
fix(drawing): clamp DrawField within img
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
2f54184625 
Closes #154
Closes #146
fix(pdf): dynamic mark scaling
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
ea09daa669 
Caveat: scaling is not fluid, refresh is required
enes added 1 commit 2024-08-26 12:10:24 +00:00
refactor(pdf): remove unused code
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
8c5be3713d
eugene requested changes 2024-08-27 09:34:15 +00:00
Dismissed
eugene left a comment
Owner
Copy Link

Looks good overall, although I would suggest that sizing should change dynamically if the user changes the size of the browser.

I would suggest:

  • either explore that possibility as part of this PR
  • or, if it falls outside of the scope of this PR, add some comments in order to make it clear that this PR will not dynamically change the size of the marks
Looks good overall, although I would suggest that sizing should change dynamically if the user changes the size of the browser. I would suggest: - either explore that possibility as part of this PR - or, if it falls outside of the scope of this PR, add some comments in order to make it clear that this PR will not dynamically change the size of the marks
enes added 1 commit 2024-08-27 13:25:29 +00:00
fix(pdf): scaling on resize, add avatars to counterpart select
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
4712031615
enes added 1 commit 2024-08-27 14:11:05 +00:00
fix(drawfield): match label and select
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 36s
Details
923a47b4d0
enes added 1 commit 2024-08-27 15:28:28 +00:00
fix(pdf): add proper default width value
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
a442e71087
enes added 1 commit 2024-08-28 09:41:37 +00:00
fix(pdf): reuse content width function
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
59c3fc69a2
enes requested review from eugene 2024-08-28 10:46:38 +00:00
eugene approved these changes 2024-08-28 11:20:07 +00:00
eugene left a comment
Owner
Copy Link

Nice one, and adding the useScale hook looks good

Nice one, and adding the `useScale` hook looks good
👍 1
enes merged commit 5570d72f79 into staging 2024-08-28 11:23:34 +00:00
enes deleted branch 146-pdf-scaling 2024-08-28 11:23:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
eugene
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#165
No description provided.
Delete Branch "146-pdf-scaling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?