sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

#215 Change Model to use FileHash #302

Closed
eugene wants to merge 1 commits from issue-215-pdf-file-hash-to-file-hash into staging
pull from: issue-215-pdf-file-hash-to-file-hash
merge into: sigit:staging
Conversation 1 Commits 1 Files Changed 5 +10 -10
eugene commented 2025-01-08 16:30:41 +00:00
Owner
Copy Link

This PR updates the Sigit model to use use naming fileHash instead of pdfFileHash.

Note: it's a breaking change.

This PR updates the Sigit model to use use naming `fileHash` instead of `pdfFileHash`. Note: it's a breaking change.
eugene added 1 commit 2025-01-08 16:30:41 +00:00
refactor: updates model to use fileHash
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details
f2f154a6c4
eugene requested review from m 2025-01-08 16:39:53 +00:00
eugene requested review from enes 2025-01-08 16:39:53 +00:00
eugene commented 2025-01-09 11:23:27 +00:00
Author
Owner
Copy Link

I'm closing this in PR in favour of the updated PR that is compatible with existing Sigits.

I'm closing this in PR in favour of [the updated PR](https://git.nostrdev.com/sigit/sigit.io/pulls/303) that is compatible with existing Sigits.
eugene closed this pull request 2025-01-09 11:23:27 +00:00
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
enes
m
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#302
No description provided.
Delete Branch "issue-215-pdf-file-hash-to-file-hash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?