sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

#215 Change Naming from PdfFileHash to FileHash #303

Merged
eugene merged 3 commits from issue-215-file-hash-naming into staging 2025-01-14 08:35:57 +00:00
Conversation 2 Commits 3 Files Changed 5 +21 -11
eugene commented 2025-01-09 11:22:47 +00:00
Owner
Copy Link

This PR updates the Sigit model to use use naming fileHash instead of pdfFileHash.

The current implementation ensures that the old Sigits remain functional.

This PR updates the Sigit model to use use naming fileHash instead of pdfFileHash. The current implementation ensures that the old Sigits remain functional.
eugene added 1 commit 2025-01-09 11:22:48 +00:00
refactor: renames to fileHash
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 44s
Details
70e7e5305e
eugene requested review from enes 2025-01-09 11:24:26 +00:00
enes approved these changes 2025-01-09 11:53:31 +00:00
b reviewed 2025-01-10 10:13:04 +00:00
src/pages/verify/index.tsx
@ -107,2 +107,3 @@
].parsedContent?.marks.filter(
(m) => m.pdfFileHash == hash && m.location.page == i
(m) =>
(m.pdfFileHash
b commented 2025-01-10 10:13:04 +00:00
Owner
Copy Link

comment here would be great (eg "backwards compatibility for sigits before Jan 2025")

comment here would be great (eg "backwards compatibility for sigits before Jan 2025")
👍 1
eugene marked this conversation as resolved
eugene added 1 commit 2025-01-14 08:30:09 +00:00
chore: adds comment
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 44s
Details
3be0fd7bbb
eugene added 1 commit 2025-01-14 08:32:32 +00:00
chore: adds comment
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 39s
Details
c69d55c3a8
eugene merged commit 2d472470be into staging 2025-01-14 08:35:57 +00:00
eugene deleted branch issue-215-file-hash-naming 2025-01-14 08:35:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
enes
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#303
No description provided.
Delete Branch "issue-215-file-hash-naming"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?