eugene eugene
  • Joined on 2024-07-03
eugene commented on pull request sigit/sigit.io#206 2024-09-19 10:32:09 +00:00
fix: #201, #145, #205 and additional fixes

Can you please add a comment to capture the difference in the codebase?

eugene commented on pull request sigit/sigit.io#207 2024-09-19 10:31:00 +00:00
fix(marks): add default signer

I think it's a fairly minor refactor and can be done as part of the same PR

eugene commented on pull request sigit/sigit.io#207 2024-09-19 10:30:10 +00:00
fix(marks): add default signer

Do you still need the other PR?

eugene opened issue sigit/sigit.io#211 2024-09-18 15:26:26 +00:00
Blossom - Tidy Up Sigit Blossom Versioning
eugene approved sigit/sigit.io#210 2024-09-18 15:21:04 +00:00
New release
eugene deleted branch blossom-upgrade from sigit/sigit.io 2024-09-18 15:09:33 +00:00
eugene pushed to staging at sigit/sigit.io 2024-09-18 15:09:33 +00:00
0091d3ec9e Merge pull request 'Update Blossom Event' (#209) from blossom-upgrade into staging
dd53ded518 fix: updates blossom authorisation event
Compare 2 commits »
eugene merged pull request sigit/sigit.io#209 2024-09-18 15:09:32 +00:00
Update Blossom Event
eugene created pull request sigit/sigit.io#209 2024-09-18 15:02:28 +00:00
Update Blossom Event
eugene pushed to blossom-upgrade at sigit/sigit.io 2024-09-18 14:57:56 +00:00
dd53ded518 fix: updates blossom authorisation event
eugene created branch blossom-upgrade in sigit/sigit.io 2024-09-18 14:57:56 +00:00
eugene commented on pull request sigit/sigit.io#207 2024-09-18 09:49:34 +00:00
fix(marks): add default signer

Should this be turned into a utilitiy function, something like getDisplayName that can then be re-used wherever needed?

eugene commented on pull request sigit/sigit.io#207 2024-09-18 09:48:59 +00:00
fix(marks): add default signer

Isn't what the first PR already doing? And similar comment to the first PR - can we rely on the active flag rather than commenting out?

eugene commented on pull request sigit/sigit.io#206 2024-09-18 09:47:04 +00:00
fix: #201, #145, #205 and additional fixes

Can we rely on the active flag rather than commenting out?

eugene approved sigit/sigit.io#204 2024-09-17 13:04:45 +00:00
fix(pdf): pdf quality and multiline

Looks good!

eugene approved sigit/sigit.io#198 2024-09-16 12:26:26 +00:00
Extension login infinite loading
eugene pushed to staging at sigit/sigit.io 2024-09-12 12:09:42 +00:00
bf1b3beb63 Merge branch 'main' into staging
09229f42c7 Merge pull request 'new release' (#190) from staging into main
Compare 2 commits »
eugene created pull request sigit/sigit.io#200 2024-09-12 12:09:01 +00:00
New Release