eugene

eugene commented on pull request sigit/sigit.io#278

2025-01-14 10:01:45 +00:00

issue-274

Instead of storing promises in a separate variable, you can pass in the functions that return promises directly in Promise.all.

eugene commented on pull request sigit/sigit.io#278

2025-01-14 10:00:57 +00:00

issue-274

What is the advantage of using a map over list/array?

eugene commented on pull request sigit/sigit.io#278

2025-01-14 09:01:23 +00:00

issue-274

If you keep the noFiles flag, the following two evaluations should be refactored using the ternary operator.

eugene commented on pull request sigit/sigit.io#278

2025-01-14 08:53:19 +00:00

issue-274

Is it the case that if there are no files found in the zip, files will be an empty array? Can we rely on the length of the files array instead of introducing the noFiles flag?

eugene commented on pull request sigit/sigit.io#278

2025-01-14 08:46:06 +00:00

issue-274

Can you please re-phrease this comment to make it clearer? Or better yet, add a comment to the overall function.

eugene deleted branch issue-215-file-hash-naming from sigit/sigit.io

2025-01-14 08:35:58 +00:00

eugene pushed to staging at sigit/sigit.io

2025-01-14 08:35:58 +00:00

2d472470be Merge pull request '#215 Change Naming from PdfFileHash to FileHash' (#303) from issue-215-file-hash-naming into staging

c69d55c3a8 chore: adds comment

3be0fd7bbb chore: adds comment

70e7e5305e refactor: renames to fileHash

Compare 4 commits »

eugene merged pull request sigit/sigit.io#303

2025-01-14 08:35:57 +00:00

#215 Change Naming from PdfFileHash to FileHash

eugene pushed to issue-215-file-hash-naming at sigit/sigit.io

2025-01-14 08:32:32 +00:00

c69d55c3a8 chore: adds comment

eugene pushed to issue-215-file-hash-naming at sigit/sigit.io

2025-01-14 08:30:09 +00:00

3be0fd7bbb chore: adds comment

eugene closed pull request sigit/sigit.io#302

2025-01-09 11:23:27 +00:00

#215 Change Model to use FileHash

eugene commented on pull request sigit/sigit.io#302

2025-01-09 11:23:27 +00:00

#215 Change Model to use FileHash

I'm closing this in PR in favour of the updated PR that is compatible with existing Sigits.

eugene created pull request sigit/sigit.io#303

2025-01-09 11:22:48 +00:00

#215 Change Naming from PdfFileHash to FileHash

eugene pushed to issue-215-file-hash-naming at sigit/sigit.io

2025-01-09 10:58:33 +00:00

70e7e5305e refactor: renames to fileHash

eugene created branch issue-215-file-hash-naming in sigit/sigit.io

2025-01-09 10:58:33 +00:00

eugene created pull request sigit/sigit.io#302

2025-01-08 16:30:41 +00:00

#215 Change Model to use FileHash

eugene pushed to issue-215-pdf-file-hash-to-file-hash at sigit/sigit.io

2025-01-08 16:28:31 +00:00

f2f154a6c4 refactor: updates model to use fileHash

eugene created branch issue-215-pdf-file-hash-to-file-hash in sigit/sigit.io

2025-01-08 16:28:31 +00:00

eugene deleted branch issue-288-sign-complete-spinner-fix from sigit/sigit.io

2025-01-08 12:25:20 +00:00

eugene pushed to staging at sigit/sigit.io

2025-01-08 12:25:19 +00:00

fdaae33aa1 Merge pull request '#288 Fixes Sign and Complete Spinner Issue' (#301) from issue-288-sign-complete-spinner-fix into staging

746338465d fix: disables redundant metaInNavState updates

Compare 2 commits »