sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: load screen on sign, block on missing counterpart #170

Merged
enes merged 7 commits from 137-sign-loading-error into staging 2024-08-29 11:02:19 +00:00
Conversation 4 Commits 7 Files Changed 8 +219 -209
enes commented 2024-08-28 11:21:59 +00:00
Member
Copy Link

Fix:

  • allow signing with no marks (enables signing images and other files)
  • adding a mark without counterpart now throws a toast error

Additional:

  • fix content column size (add wrapping)

Closes #137

Fix: - allow signing with no marks (enables signing images and other files) - adding a mark without counterpart now throws a toast error Additional: - fix content column size (add wrapping) Closes #137
enes added 15 commits 2024-08-28 11:21:59 +00:00 
Closes #146
fix(pdf): dynamic mark scaling
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
ea09daa669 
Caveat: scaling is not fluid, refresh is required
refactor(pdf): remove unused code
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
8c5be3713d
fix(pdf): scaling on resize, add avatars to counterpart select
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
4712031615
fix(drawfield): match label and select
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 36s
Details
923a47b4d0
fix(pdf): add proper default width value
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
a442e71087
fix(pdf): reuse content width function
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
59c3fc69a2
fix(sign): allow signing without marks, hide loading and show toast for prevSig error
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 37s
Details
35b1378aa7
enes force-pushed 137-sign-loading-error from 35b1378aa7 to 20d1170f7d 2024-08-28 11:26:52 +00:00 Compare
enes requested review from eugene 2024-08-28 12:14:07 +00:00
eugene reviewed 2024-08-29 09:43:22 +00:00
src/pages/create/index.tsx
@ -727,3 +730,1 @@
setLoadingSpinnerDesc('Generating file hashes')
const fileHashes = await generateFileHashes()
if (!fileHashes) {
setIsLoading(true)
eugene commented 2024-08-29 09:43:22 +00:00
Owner
Copy Link

I wonder if this flow should be refactored, given our recent conversation about error handling. I also thing that there are more efficient ways to handle loading state changes.

Having said that, perhaps it is best left to a separate PR. Worth adding as an issue?

I wonder if this flow should be refactored, given our recent conversation about error handling. I also thing that there are more efficient ways to handle loading state changes. Having said that, perhaps it is best left to a separate PR. Worth adding as an issue?
👍 1
enes commented 2024-08-29 10:25:32 +00:00
Author
Member
Copy Link

I think we can for now just leave finally, to execute setIsLoading(false) once, we don't need it in each return

I think we can for now just leave `finally`, to execute `setIsLoading(false)` once, we don't need it in each return
eugene reviewed 2024-08-29 09:44:14 +00:00
src/pages/create/index.tsx
@ -730,0 +804,4 @@
setLoadingSpinnerDesc('Sending notifications to counterparties')
const promises = sendNotifications(meta)
await Promise.all(promises)
eugene commented 2024-08-29 09:44:14 +00:00
Owner
Copy Link

A promise doesn't need to be awaited if chaining is used.

A promise doesn't need to be awaited if chaining is used.
enes commented 2024-08-29 10:17:25 +00:00
Author
Member
Copy Link

We are blocking so we don't navigate away before .all is done.
Another question is if we need to block at all since even if it's rejected, we proceed to another page anyway?

We are blocking so we don't navigate away before `.all` is done. Another question is if we need to block at all since even if it's rejected, we proceed to another page anyway?
eugene reviewed 2024-08-29 09:44:40 +00:00
src/pages/sign/index.tsx
@ -543,3 +543,3 @@
const prevSig = getPrevSignersSig(hexToNpub(usersPubkey!))
if (!prevSig) return
if (!prevSig) {
eugene commented 2024-08-29 09:44:40 +00:00
Owner
Copy Link

Same here, re refactoring.

Same here, re refactoring.
eugene approved these changes 2024-08-29 09:45:40 +00:00
enes added 1 commit 2024-08-29 10:55:01 +00:00
refactor(review): handle loading state, browser warnings
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
e2b12afc72
enes merged commit 791c213e3a into staging 2024-08-29 11:02:19 +00:00
enes deleted branch 137-sign-loading-error 2024-08-29 11:02:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
eugene
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#170
No description provided.
Delete Branch "137-sign-loading-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?