fix: #201, #145, #205 and additional fixes #206

Merged
enes merged 14 commits from 201-toolbox-update into staging 2024-09-30 14:20:07 +00:00
Member

Closes #201 - reduce the size of the toolbox and rename properties for clarity
Closes #145 - default signer and last signer
Closes #205 - username consistency

Additional changes:

  • counterpart design updated on create page
  • select counterpart state (activeDrawnField fix)
  • refactor create/index.tsx and DrawPDFFields.index.tsx
  • removing user updates marks correctly
Closes #201 - reduce the size of the toolbox and rename properties for clarity Closes #145 - default signer and last signer Closes #205 - username consistency Additional changes: - counterpart design updated on create page - select counterpart state (`activeDrawnField` fix) - refactor `create/index.tsx` and `DrawPDFFields.index.tsx` - removing user updates marks correctly
enes added 1 commit 2024-09-17 15:27:02 +00:00
refactor(toolbox): reduce number of mark types
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
f8a4480994
Closes #201
eugene reviewed 2024-09-18 09:47:04 +00:00
@ -261,3 +179,2 @@
label: 'Phone',
active: false
}
// {
Owner

Can we rely on the active flag rather than commenting out?

Can we rely on the `active` flag rather than commenting out?
Author
Member

The active flag is for coming soon currently, and instead of adding a new flag to differentiate between coming soon and visually hidden, I opted to comment out.

The active flag is for `coming soon` currently, and instead of adding a new flag to differentiate between coming soon and visually hidden, I opted to comment out.
Owner

Can you please add a comment to capture the difference in the codebase?

Can you please add a comment to capture the difference in the codebase?
Author
Member

Okay, made it clearer with new property names, isHidden and isComingSoon so there is no confusion as with active (also removed comments and used isHidden instead).

Okay, made it clearer with new property names, `isHidden` and `isComingSoon` so there is no confusion as with `active` (also removed comments and used `isHidden` instead).
enes added 1 commit 2024-09-19 10:00:47 +00:00
Merge branch 'staging' into 201-toolbox-update
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
182ef40d8d
enes added 1 commit 2024-09-19 11:16:04 +00:00
refactor: better variable names
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
f81f2b0523
enes added 4 commits 2024-09-19 11:24:18 +00:00
fix(marks): add default signer
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
dfdcb8419d
fix: last signer as default next
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
39934f59c3
chore(git): merge pull request #207 from 145-default-signer into 201-toolbox-update
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
a1bf88d243
Reviewed-on: #207
enes changed title from refactor(toolbox): reduce number of mark types to WIP: refactor(toolbox): reduce number of mark types 2024-09-19 11:26:47 +00:00
enes added 1 commit 2024-09-19 11:31:04 +00:00
Merge branch 'staging' into 201-toolbox-update
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
9bae5b9ba2
enes added 5 commits 2024-09-20 09:13:58 +00:00
enes changed title from WIP: refactor(toolbox): reduce number of mark types to refactor(toolbox): reduce number of mark types 2024-09-20 09:36:42 +00:00
enes changed title from refactor(toolbox): reduce number of mark types to fix: 201, 145, 205 and additional fixes 2024-09-20 09:37:25 +00:00
enes changed title from fix: 201, 145, 205 and additional fixes to fix: #201, #145, #205 and additional fixes 2024-09-20 09:37:33 +00:00
enes added 1 commit 2024-09-23 08:09:49 +00:00
refactor: center banner notice text
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
633c23e459
eugene approved these changes 2024-09-30 13:10:00 +00:00
enes merged commit 8da2510a18 into staging 2024-09-30 14:20:07 +00:00
enes deleted branch 201-toolbox-update 2024-09-30 14:20:08 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#206
No description provided.