sigit/sigit.io
6
2
Fork 0
Code Issues 41 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: #201, #145, #205 and additional fixes #206

Open
enes wants to merge 13 commits from 201-toolbox-update into staging
pull from: 201-toolbox-update
merge into: sigit:staging
Conversation 0 Commits 13 Files Changed 10 +308 -228
enes commented 2024-09-17 15:27:02 +00:00
Member
Copy Link

Closes #201 - reduce the size of the toolbox and rename properties for clarity
Closes #145 - default signer and last signer
Closes #205 - username consistency

Additional changes:

  • counterpart design updated on create page
  • select counterpart state (activeDrawnField fix)
  • refactor create/index.tsx and DrawPDFFields.index.tsx
  • removing user updates marks correctly
Closes #201 - reduce the size of the toolbox and rename properties for clarity Closes #145 - default signer and last signer Closes #205 - username consistency Additional changes: - counterpart design updated on create page - select counterpart state (`activeDrawnField` fix) - refactor `create/index.tsx` and `DrawPDFFields.index.tsx` - removing user updates marks correctly
enes added 1 commit 2024-09-17 15:27:02 +00:00
refactor(toolbox): reduce number of mark types
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
f8a4480994 
Closes #201
eugene reviewed 2024-09-18 09:47:04 +00:00
src/utils/mark.ts Outdated
@ -261,3 +179,2 @@
label: 'Phone',
active: false
}
// {
eugene commented 2024-09-18 09:47:04 +00:00
Owner
Copy Link

Can we rely on the active flag rather than commenting out?

Can we rely on the `active` flag rather than commenting out?
enes commented 2024-09-18 09:54:12 +00:00
Author
Member
Copy Link

The active flag is for coming soon currently, and instead of adding a new flag to differentiate between coming soon and visually hidden, I opted to comment out.

The active flag is for `coming soon` currently, and instead of adding a new flag to differentiate between coming soon and visually hidden, I opted to comment out.
eugene commented 2024-09-19 10:32:09 +00:00
Owner
Copy Link

Can you please add a comment to capture the difference in the codebase?

Can you please add a comment to capture the difference in the codebase?
enes commented 2024-09-19 11:18:05 +00:00
Author
Member
Copy Link

Okay, made it clearer with new property names, isHidden and isComingSoon so there is no confusion as with active (also removed comments and used isHidden instead).

Okay, made it clearer with new property names, `isHidden` and `isComingSoon` so there is no confusion as with `active` (also removed comments and used `isHidden` instead).
enes added 1 commit 2024-09-19 10:00:47 +00:00
Merge branch 'staging' into 201-toolbox-update
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
182ef40d8d
enes added 1 commit 2024-09-19 11:16:04 +00:00
refactor: better variable names
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
f81f2b0523
enes added 4 commits 2024-09-19 11:24:18 +00:00
fix(marks): add default signer
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
dfdcb8419d
fix: last signer as default next
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
39934f59c3
chore(git): merge pull request #207 from 145-default-signer into 201-toolbox-update
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
a1bf88d243 
Reviewed-on: #207
enes changed title from refactor(toolbox): reduce number of mark types to WIP: refactor(toolbox): reduce number of mark types 2024-09-19 11:26:47 +00:00
enes added 1 commit 2024-09-19 11:31:04 +00:00
Merge branch 'staging' into 201-toolbox-update
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
9bae5b9ba2
enes added 5 commits 2024-09-20 09:13:58 +00:00
refactor: rename userId to npub
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
2e1d48168a
enes changed title from WIP: refactor(toolbox): reduce number of mark types to refactor(toolbox): reduce number of mark types 2024-09-20 09:36:42 +00:00
enes changed title from refactor(toolbox): reduce number of mark types to fix: 201, 145, 205 and additional fixes 2024-09-20 09:37:25 +00:00
enes changed title from fix: 201, 145, 205 and additional fixes to fix: #201, #145, #205 and additional fixes 2024-09-20 09:37:33 +00:00
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 201-toolbox-update:201-toolbox-update
git checkout 201-toolbox-update
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#206
No description provided.
Delete Branch "201-toolbox-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?