eugene eugene
  • Joined on 2024-07-03
eugene opened issue sigit/sigit.io#145 2024-08-15 13:21:27 +00:00
Create Page - Marks Should be Assigned a Signer
eugene pushed to sigit-info-signing-page at sigit/sigit.io 2024-08-15 12:35:43 +00:00
ed7acd6cb4 feat(pdf-marking): adds file validity check
eugene created branch sigit-info-signing-page in sigit/sigit.io 2024-08-15 09:25:48 +00:00
eugene pushed to sigit-info-signing-page at sigit/sigit.io 2024-08-15 09:25:48 +00:00
b22f577cc2 fix: marking
2becab9f79 feat(pdf-marking): integrates UserDetails
Compare 2 commits »
eugene pushed to signing-page-design at sigit/sigit.io 2024-08-14 14:23:06 +00:00
7d3daa8d13 chore: git merge 136-verify-pageo signing-page-design
bff590f532 Merge branch 'staging' into signing-page-design
2f29ea9f35 fix: styling
1c3d3ca88f refactor: pass meta to UserDetails instead of individual props
d8adb2c744 fix: next signer and spinner anim duration
Compare 71 commits »
eugene created branch signing-page-design in sigit/sigit.io 2024-08-14 13:08:51 +00:00
eugene pushed to signing-page-design at sigit/sigit.io 2024-08-14 13:08:51 +00:00
d41d577c29 fix: styling
64dbd7d479 feat(pdf-marking): integrates layouts
50c8f2b2d0 refactor: rename Files to StickySideColumns and update css
dfe67b99ad feat: add sticky layout with slots
97c82718cb fix: page scrolling
Compare 10 commits »
eugene approved sigit/sigit.io#135 2024-08-13 08:34:00 +00:00
feat(design): home page new design and functionality

Looks good overall, and good job on adding the Sigit Meta hook.

eugene commented on pull request sigit/sigit.io#135 2024-08-13 08:31:48 +00:00
feat(design): home page new design and functionality

created_at * 1000 should be made into a utility function and used in other similar places (there is at least one that I could find).

eugene commented on pull request sigit/sigit.io#135 2024-08-09 11:34:09 +00:00
feat(design): home page new design and functionality

Looks good, but I left one comment about the useSigitMeta hook. I believe it should be extended so that it can be used across the full Sigit flow.

eugene commented on pull request sigit/sigit.io#135 2024-08-09 11:30:18 +00:00
feat(design): home page new design and functionality

Should SigitInfo returned by hook also contain other information available in Meta, specifically in the createSignature string, i.e. CreateSIgnatureEventContent? Similarly, should the data from docSignatures, represented by SignedEventContent be returned as well?

eugene approved sigit/sigit.io#134 2024-08-08 11:03:57 +00:00
Staging fixes

Looks good.

eugene commented on pull request sigit/sigit.io#124 2024-08-08 11:02:29 +00:00
issue-99-signing-page-refactor

This PR has been merged as part of the issue-99 PR. Closing.

eugene closed pull request sigit/sigit.io#124 2024-08-08 11:02:29 +00:00
issue-99-signing-page-refactor
eugene pushed to staging at sigit/sigit.io 2024-08-08 09:44:21 +00:00
88d988e60b Merge pull request 'PDFjs Import Fix' (#133) from pdfjs-worker-fix into staging
50b406d83a Merge branch 'staging' into pdfjs-worker-fix
d5e0769692 fix: pdfjs import
Compare 3 commits »
eugene deleted branch pdfjs-worker-fix from sigit/sigit.io 2024-08-08 09:44:21 +00:00
eugene merged pull request sigit/sigit.io#133 2024-08-08 09:44:19 +00:00
PDFjs Import Fix
eugene pushed to pdfjs-worker-fix at sigit/sigit.io 2024-08-08 09:43:05 +00:00
50b406d83a Merge branch 'staging' into pdfjs-worker-fix
b0ba2b9b4d Merge pull request 'Hotfix - Linting Error' (#132) from formatting-hotfix into staging
f80d4d7b67 chore: prettier
Compare 3 commits »
eugene created pull request sigit/sigit.io#133 2024-08-08 09:40:29 +00:00
PDFjs Import Fix
eugene created branch pdfjs-worker-fix in sigit/sigit.io 2024-08-08 09:39:38 +00:00