eugene

eugene commented on pull request sigit/sigit.io#170

2024-08-29 09:44:14 +00:00

fix: load screen on sign, block on missing counterpart

A promise doesn't need to be awaited if chaining is used.

eugene commented on pull request sigit/sigit.io#170

2024-08-29 09:43:22 +00:00

fix: load screen on sign, block on missing counterpart

I wonder if this flow should be refactored, given our recent conversation about error handling. I also thing that there are more efficient ways to handle loading state changes.

eugene approved sigit/sigit.io#165

2024-08-28 11:20:07 +00:00

fix(pdf): dynamic mark scaling

Nice one, and adding the useScale hook looks good

eugene deleted branch issue-158 from sigit/sigit.io

2024-08-28 08:41:35 +00:00

eugene pushed to staging at sigit/sigit.io

2024-08-28 08:41:35 +00:00

9dc160e89c Merge pull request 'Signing Order' (#167) from issue-158 into staging

ec305c417b fix: signing order

Compare 2 commits »

eugene merged pull request sigit/sigit.io#167

2024-08-28 08:41:33 +00:00

Signing Order

eugene commented on issue sigit/sigit.io#142

2024-08-27 14:09:39 +00:00

Sign Page - Navigates back to /sign after singing

I've not been able to reproduce this issue. Unless other people still encounter it, I'm going to close it. @b @enes @freakoverse

eugene opened issue sigit/sigit.io#168

2024-08-27 13:25:42 +00:00

Signing Page - Sigit Not Updated With 2+ Signers

eugene commented on issue sigit/sigit.io#158

2024-08-27 13:23:01 +00:00

Sign Page - Sign order issue when creator signs second

Following the PR with a fix, I have performed 3 tests.

Test 1.

Npub1: Creator and Signer 1 Npub2: Signer 2

Once the sigit is created,…

eugene created pull request sigit/sigit.io#167

2024-08-27 13:21:10 +00:00

Signing Order

eugene pushed to issue-158 at sigit/sigit.io

2024-08-27 13:17:44 +00:00

ec305c417b fix: signing order

eugene created branch issue-158 in sigit/sigit.io

2024-08-27 13:17:44 +00:00

eugene suggested changes for sigit/sigit.io#165

2024-08-27 09:34:15 +00:00

fix(pdf): dynamic mark scaling

Looks good overall, although I would suggest that sizing should change dynamically if the user changes the size of the browser.

eugene approved sigit/sigit.io#164

2024-08-27 09:24:16 +00:00

fix(drawing): clamp DrawField within img

eugene approved sigit/sigit.io#161

2024-08-21 11:38:12 +00:00

Releasing new design

eugene approved sigit/sigit.io#160

2024-08-21 10:49:28 +00:00

fix: useSigitProfiles dep, map item keys warnining, sign button styles, placeholder, optional button label

eugene commented on pull request sigit/sigit.io#160

2024-08-21 10:49:01 +00:00

fix: useSigitProfiles dep, map item keys warnining, sign button styles, placeholder, optional button label

You can probably use the ?? operator. Should Download Files be a constant?

eugene deleted branch reduce-relay-connection-attempts from sigit/sigit.io

2024-08-21 08:06:39 +00:00

eugene pushed to staging at sigit/sigit.io

2024-08-21 08:06:39 +00:00

35f6a639e6 Merge pull request 'fix: manage pending relay connection requests' (#159) from reduce-relay-connection-attempts into staging

d7b5ea9b9e fix: use default relayMap if its undefined in redux store

c1b1c5a075 Merge branch 'staging' into reduce-relay-connection-attempts

4a553c047c chore: addressed PR comments

42d74c656a fix: in pdf marking if counterpart does not have any of name, displayname, username then show pubkey

Compare 7 commits »

eugene merged pull request sigit/sigit.io#159

2024-08-21 08:06:39 +00:00

fix: manage pending relay connection requests